Add '--host' option to testserver.py and expose it via a new TestServer constructor.

net/test/test_server.h

Index: net/test/test_server.h
diff --git a/net/test/test_server.h b/net/test/test_server.h
index 18c142011b635738ae4c11955b08ff5517083dec..800fc3d684ca465f1a93356c075e727d27cdf947 100644
--- a/net/test/test_server.h
+++ b/net/test/test_server.h
@@ -110,8 +110,14 @@ class TestServer {
     bool record_resume;
   };
 
+  // Initialize a TestServer listening on 127.0.0.1.
   TestServer(Type type, const FilePath& document_root);
 
+  // Initialize a TestServer listening on a specific host (IP or hostname).

[Paweł Hajdan Jr., 2012/02/15 17:13:10]

Please don't add a 3rd ctor. Fit it into existing one, and change callers.

Rationale: simplicity.

[erikwright (departed), 2012/02/16 14:31:02]

This would touch something on the order of 64 files according to git grep. I
have reservations about that, since it means 64 files will now need to
explicitly declare something that really is the default, whereas only one file
needs to do anything different.

Also, the medium term hope is that we will sort out the underlying problem and
we will be able to run the chrome_frame_net_tests over loopback again, in which
case we would possibly want to remove this functionality.

I see three options:

1) Add a third constructor.
2) Add a setter, instead. It violates the existing conventions for the class,
but it doesn't bother me that much.
3) Temporarily add a third constructor, submit one or more CLs to update the
existing clients to use it, and then submit a final CL to remove the old
constructor.

If not adding a 3rd constructor is your strong preference, I will get all the
CLs for (3) lined up before the first commit. I would ask your preference for
how the 64 files should specify localhost:

a) empty string
b) literal 127.0.0.1
c) define a net::TestServer::kLocalHost

A quick query did not reveal an existing constant for localhost.

+  TestServer(Type type,
+             const std::string& host,
+             const FilePath& document_root);
+
   // Initialize a HTTPS TestServer with a specific set of HTTPSOptions.
   TestServer(const HTTPSOptions& https_options,
              const FilePath& document_root);
@@ -144,7 +150,7 @@ class TestServer {
       std::string* replacement_path);
 
  private:
-  void Init(const FilePath& document_root);
+  void Init(const std::string& host, const FilePath& document_root);
 
   // Modify PYTHONPATH to contain libraries we need.
   bool SetPythonPath() WARN_UNUSED_RESULT;