Add '--host' option to testserver.py and expose it via a new TestServer constructor.

net/test/test_server.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_TEST_SERVER_H_
 #define NET_TEST_TEST_SERVER_H_
 #pragma once
 
 #include <string>
 #include <utility>
@@ skipping 92 matching lines @@
     // HTTPS server, or BULK_CIPHER_ANY to indicate that all implemented
     // ciphers are acceptable.
     int bulk_ciphers;
 
     // If true, pass the --https-record-resume argument to testserver.py which
     // causes it to log session cache actions and echo the log on
     // /ssl-session-cache.
     bool record_resume;
   };
 
+  // Initialize a TestServer listening on 127.0.0.1.
   TestServer(Type type, const FilePath& document_root);
 
+  // Initialize a TestServer listening on a specific host (IP or hostname).

[Paweł Hajdan Jr., 2012/02/15 17:13:10]

Please don't add a 3rd ctor. Fit it into existing one, and change callers.

Rationale: simplicity.

[erikwright (departed), 2012/02/16 14:31:02]

This would touch something on the order of 64 files according to git grep. I
have reservations about that, since it means 64 files will now need to
explicitly declare something that really is the default, whereas only one file
needs to do anything different.

Also, the medium term hope is that we will sort out the underlying problem and
we will be able to run the chrome_frame_net_tests over loopback again, in which
case we would possibly want to remove this functionality.

I see three options:

1) Add a third constructor.
2) Add a setter, instead. It violates the existing conventions for the class,
but it doesn't bother me that much.
3) Temporarily add a third constructor, submit one or more CLs to update the
existing clients to use it, and then submit a final CL to remove the old
constructor.

If not adding a 3rd constructor is your strong preference, I will get all the
CLs for (3) lined up before the first commit. I would ask your preference for
how the 64 files should specify localhost:

a) empty string
b) literal 127.0.0.1
c) define a net::TestServer::kLocalHost

A quick query did not reveal an existing constant for localhost.

+  TestServer(Type type,
+             const std::string& host,
+             const FilePath& document_root);
+
   // Initialize a HTTPS TestServer with a specific set of HTTPSOptions.
   TestServer(const HTTPSOptions& https_options,
              const FilePath& document_root);
 
   ~TestServer();
 
   bool Start() WARN_UNUSED_RESULT;
 
   // Stop the server started by Start().
   bool Stop();
@@ skipping 12 matching lines @@
   GURL GetURLWithUserAndPassword(const std::string& path,
                                  const std::string& user,
                                  const std::string& password) const;
 
   static bool GetFilePathWithReplacements(
       const std::string& original_path,
       const std::vector<StringPair>& text_to_replace,
       std::string* replacement_path);
 
  private:
-  void Init(const FilePath& document_root);
+  void Init(const std::string& host, const FilePath& document_root);
 
   // Modify PYTHONPATH to contain libraries we need.
   bool SetPythonPath() WARN_UNUSED_RESULT;
 
   // Launches the Python test server. Returns true on success.
   bool LaunchPython(const FilePath& testserver_path) WARN_UNUSED_RESULT;
 
   // Waits for the server to start. Returns true on success.
   bool WaitToStart() WARN_UNUSED_RESULT;
 
@@ skipping 55 matching lines @@
 
   // Enables logging of the server to the console.
   bool log_to_console_;
 
   DISALLOW_COPY_AND_ASSIGN(TestServer);
 };
 
 }  // namespace net
 
 #endif  // NET_TEST_TEST_SERVER_H_