Expose a static configuration value for the host to use for URLRequestTestHTTP tests.

net/url_request/url_request_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_test_util.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/threading/thread.h"
@@ skipping 486 matching lines @@
   event_order_[req_id] += "OnAuthRequired\n";
   EXPECT_TRUE(next_states_[req_id] & kStageAuthRequired) <<
       event_order_[req_id];
   next_states_[req_id] = kStageBeforeSendHeaders |
       kStageHeadersReceived |  // Request canceled by delegate simulates empty
                                // response.
       kStageResponseStarted |  // data: URLs do not trigger sending headers
       kStageBeforeRedirect;  // a delegate can trigger a redirection
   return net::NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION;
 }
+
+std::string CustomUrlRequestTestHttpHost::value_("127.0.0.1");

[Paweł Hajdan Jr., 2012/02/17 11:06:36]

nit: // static above

[erikwright (departed), 2012/02/17 17:48:12]

It doesn't compile with a static here:

1>.\url_request\url_request_test_util.cc(508) : error C2720:
'ScopedCustomUrlRequestTestHttpHost::value_' : 'static ' storage-class specifier
illegal on members

[Paweł Hajdan Jr., 2012/02/21 16:56:35]

We have a convention to add it as a *comment* .

+
+CustomUrlRequestTestHttpHost::CustomUrlRequestTestHttpHost(

[Paweł Hajdan Jr., 2012/02/17 11:06:36]

Where is this instantiated?

[erikwright (departed), 2012/02/17 11:15:21]

In fake_external_tab.cc. I have not yet uploaded the patch to that CL that
adjusts it to use this.

[erikwright (departed), 2012/02/17 17:48:12]

See
http://codereview.chromium.org/9401013/diff/8001/chrome_frame/test/net/fake_e...

+  const std::string& value) {
+  value_ = value;
+}
+
+CustomUrlRequestTestHttpHost::~CustomUrlRequestTestHttpHost() {
+  value_ = "127.0.0.1";

[Paweł Hajdan Jr., 2012/02/17 11:06:36]

This doesn't allow stacking. It'd be better to store the original value and
restore it afterwards.

[erikwright (departed), 2012/02/17 11:15:21]

Presumably it will be OK to support naive (i.e., fully nested) stacking?

[erikwright (departed), 2012/02/17 17:48:12]

Done.

+}
+
+const std::string& CustomUrlRequestTestHttpHost::value() {

[Paweł Hajdan Jr., 2012/02/17 11:06:36]

nit: // static above

[erikwright (departed), 2012/02/17 17:48:12]

Doesn't compile:

1>.\url_request\url_request_test_util.cc(522) : error C2724:
'ScopedCustomUrlRequestTestHttpHost::value' : 'static' should not be used on
member functions defined at file scope

+  return value_;
+}