Don't run chrome_frame_net_tests URLRequestTestHTTP over loopback, due to mysterious failures.

chrome_frame/test/net/fake_external_tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/net/fake_external_tab.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <exdisp.h>
+#include <Winsock2.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
@@ skipping 29 matching lines @@
 #include "chrome_frame/test/simulate_input.h"
 #include "chrome_frame/test/win_event_receiver.h"
 #include "chrome_frame/utils.h"
 #include "content/public/app/content_main.h"
 #include "content/public/app/startup_helper_win.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_paths.h"
+#include "net/base/net_util.h"
 #include "sandbox/src/sandbox_types.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // We must store this globally so that our main delegate can set it.
@@ skipping 447 matching lines @@
   // Value: 0
 }
 
 void CFUrlRequestUnittestRunner::ShutDownHostBrowser() {
   if (ShouldLaunchBrowser()) {
     base::win::ScopedCOMInitializer com;
     chrome_frame_test::CloseAllIEWindows();
   }
 }
 
-// Override virtual void Initialize to not call icu initialize
+// Override virtual void Initialize to not call icu initialize.
 void CFUrlRequestUnittestRunner::Initialize() {
   DCHECK(::GetCurrentThreadId() == test_thread_id_);
 
   // Start by replicating some of the steps that would otherwise be
   // done by TestSuite::Initialize.  We can't call the base class
   // directly because it will attempt to initialize some things such as
   // ICU that have already been initialized for this process.
   CFUrlRequestUnittestRunner::InitializeLogging();
 
   if (!CommandLine::ForCurrentProcess()->HasSwitch(kNoCrashService)) {
     SuppressErrorDialogs();
     base::debug::SetSuppressDebugUI(true);
   }
   logging::SetLogAssertHandler(UnitTestAssertHandler);
 
   // Next, do some initialization for NetTestSuite.
   NetTestSuite::InitializeTestThreadNoNetworkChangeNotifier();
+
+  // Finally, override the host used by the HTTP tests. See
+  // http://crbug.com/114369 .
+  OverrideHttpHost();
 }
 
 void CFUrlRequestUnittestRunner::Shutdown() {
   DCHECK(::GetCurrentThreadId() == test_thread_id_);
   NetTestSuite::Shutdown();
   OleUninitialize();
 }
 
 void CFUrlRequestUnittestRunner::OnConnectAutomationProviderToChannel(
     const std::string& channel_id) {
@@ skipping 54 matching lines @@
       log_filename.value().c_str(),
       logging::LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG,
       logging::LOCK_LOG_FILE,
       logging::DELETE_OLD_LOG_FILE,
       logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
   // We want process and thread IDs because we may have multiple processes.
   // Note: temporarily enabled timestamps in an effort to catch bug 6361.
   logging::SetLogItems(true, true, true, true);
 }
 
+void CFUrlRequestUnittestRunner::OverrideHttpHost() {
+  net::NetworkInterfaceList nic_list;
+  if (!net::GetNetworkList(&nic_list)) {
+    LOG(ERROR) << "GetNetworkList failed to look up non-loopback adapters. "
+               << "Tests will be run over the loopback adapter, which may "
+               << "result in hangs.";
+    return;
+  }
+
+  for (size_t i = 0; i < nic_list.size(); ++i) {

[robertshield, 2012/02/17 17:40:55]

Consider adding a comment that we intentionally pick the first adapter found
with an address.

+    if (nic_list[i].address.size() != net::kIPv4AddressSize)
+      continue;
+    char* address_string =
+        inet_ntoa(*reinterpret_cast<in_addr*>(&nic_list[i].address[0]));
+    DCHECK(address_string != NULL);
+    if (address_string == NULL)
+      continue;
+    LOG(INFO) << "HTTP tests will run over " << address_string << ".";
+    override_http_host_.reset(new CustomUrlRequestTestHttpHost(address_string));
+    return;
+  }
+
+  LOG(ERROR) << "Failed to find a non-loopback IP_V4 address. Tests will be "
+             << "run over the loopback adapter, which may result in hangs.";
+}
+
 void CFUrlRequestUnittestRunner::PreEarlyInitialization() {
   testing::InitGoogleTest(&g_argc, g_argv);
   FilterDisabledTests();
 }
 
 MessageLoop* CFUrlRequestUnittestRunner::GetMainMessageLoop() {
   return NULL;
 }
 
 int CFUrlRequestUnittestRunner::PreCreateThreads() {
@@ skipping 127 matching lines @@
   // content::InitializeSandboxInfo(&sandbox_info);
   FakeMainDelegate delegate;
   content::ContentMain(
       reinterpret_cast<HINSTANCE>(GetModuleHandle(NULL)),
       &sandbox_info,
       &delegate);
 
   // Note:  In debug builds, we ExitProcess during PostDestroyThreads.
   return g_test_suite->test_result();
 }