Create values for literal Strings.

frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 533 matching lines @@
     buffer.add('new $jsClassReference(');
     // We can't use 'visitArguments', since our arguments start at input[0].
     List<HInstruction> inputs = node.inputs;
     for (int i = 0; i < inputs.length; i++) {
       if (i != 0) buffer.add(', ');
       use(inputs[i]);
     }
     buffer.add(')');
   }
 
-  /**
-   * Write the contents of the quoted string to a [StringBuffer] in
-   * a form that is valid as JavaScript string literal content.
-   * The string is assumed quoted by single quote characters.
-   */
-  static void writeEscapedString(DartString string,
-                                 StringBuffer buffer,
-                                 void cancel(String reason)) {
-    Iterator<int> iterator = string.iterator();
-    while (iterator.hasNext()) {
-      int code = iterator.next();
-      if (code === $SQ) {
-        buffer.add(@"\'");
-      } else if (code === $LF) {
-        buffer.add(@'\n');
-      } else if (code === $CR) {
-        buffer.add(@'\r');
-      } else if (code === $LS) {
-        // This Unicode line terminator and $PS are invalid in JS string
-        // literals.
-        buffer.add(@'\u2028');
-      } else if (code === $PS) {
-        buffer.add(@'\u2029');
-      } else if (code === $BACKSLASH) {
-        buffer.add(@'\\');
-      } else {
-        if (code > 0xffff) {
-          cancel("Unhandled non-BMP character: U+" + code.toRadixString(16));
-        }
-        // TODO(lrn): Consider whether all codes above 0x7f really need to
-        // be escaped. We build a Dart string here, so it should be a literal
-        // stage that converts it to, e.g., UTF-8 for a JS interpreter.
-        if (code < 0x20) {
-          buffer.add(@'\x');
-          if (code < 0x10) buffer.add('0');
-          buffer.add(code.toRadixString(16));
-        } else if (code >= 0x80) {
-          if (code < 0x100) {
-            buffer.add(@'\x');
-            buffer.add(code.toRadixString(16));
-          } else {
-            buffer.add(@'\u');
-            if (code < 0x1000) {
-              buffer.add('0');
-            }
-            buffer.add(code.toRadixString(16));
-          }
-        } else {
-          buffer.add(new String.fromCharCodes(<int>[code]));
-        }
-      }
-    }
-  }
-
-
   visitLiteral(HLiteral node) {
     if (node.isLiteralNull()) {
       buffer.add("(void 0)");
     } else if (node.value is num && node.value < 0) {
       buffer.add('(${node.value})');
     } else if (node.isLiteralString()) {
       DartString string = node.value;
       buffer.add("'");
-      writeEscapedString(string, buffer,
-                         (String reason) {
-                           compiler.cancel(reason, instruction:node);
-                         });
+      CompileTimeConstantHandler.writeEscapedString(string, buffer,
+                                                    (String reason) {
+        compiler.cancel(reason, instruction:node);

[floitsch, 2012/02/14 16:08:02]

space after instruction:

[karlklose, 2012/02/15 10:37:30]

Done.

+      });
       buffer.add("'");
     } else {
       buffer.add(node.value);
     }
   }
 
   visitLoopBranch(HLoopBranch node) {
     HBasicBlock branchBlock = currentBlock;
     handleLoopCondition(node);
     List<HBasicBlock> dominated = currentBlock.dominatedBlocks;
@@ skipping 557 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasBailouts()) {
       endBailoutSwitch();
     }
   }
 }