Create values for literal Strings.

Create values for literal Strings.

Committed: https://code.google.com/p/dart/source/detail?r=4254

[floitsch, 2012-02-14 10:40:57]

As discussed: we need to move the writeEscapedString from codegen to the
CompileTimeConstantHandler.

http://codereview.chromium.org/9360039/diff/5/frog/leg/compile_time_constants...
File frog/leg/compile_time_constants.dart (right):

http://codereview.chromium.org/9360039/diff/5/frog/leg/compile_time_constants...
frog/leg/compile_time_constants.dart:99: if (value is SourceString) return
value.stringValue;
The string must be escaped.
Please also add a small test-case (eg: "\u{20}" == " ").

[karlklose, 2012-02-14 14:08:05]

Thanks for the pointers Florian and Lasse.

PTAL.

[floitsch, 2012-02-14 16:08:02]

LGTM!
can you verify if ssa still needs to import ../util/characters.dart.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/compile_tim...
File frog/leg/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/compile_tim...
frog/leg/compile_time_constants.dart:99: buffer.add("$value");
not your code, but could you please add parenthesis around negative numbers
(num.isNegative()).

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/emitter.dart
File frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/emitter.dar...
frog/leg/emitter.dart:110: var value = constants.writeJsCodeForVariable(new
StringBuffer(), element);
80 chars.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/leg.dart
File frog/leg/leg.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/leg.dart#ne...
frog/leg/leg.dart:17: #import('util/characters.dart');
sort alphabetically.
(also please fix the string_validator).

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/ssa/codegen...
File frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/ssa/codegen...
frog/leg/ssa/codegen.dart:564: compiler.cancel(reason, instruction:node);
space after instruction:

[karlklose, 2012-02-15 10:37:30]

Thanks for the review, Florian.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/compile_tim...
File frog/leg/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/compile_tim...
frog/leg/compile_time_constants.dart:99: buffer.add("$value");
On 2012/02/14 16:08:02, floitsch wrote:
> not your code, but could you please add parenthesis around negative numbers
> (num.isNegative()).

Done.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/emitter.dart
File frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/emitter.dar...
frog/leg/emitter.dart:110: var value = constants.writeJsCodeForVariable(new
StringBuffer(), element);
On 2012/02/14 16:08:02, floitsch wrote:
> 80 chars.

Done.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/leg.dart
File frog/leg/leg.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/leg.dart#ne...
frog/leg/leg.dart:17: #import('util/characters.dart');
On 2012/02/14 16:08:02, floitsch wrote:
> sort alphabetically.
> (also please fix the string_validator).

Done.

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/ssa/codegen...
File frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9360039/diff/6001/frog/leg/ssa/codegen...
frog/leg/ssa/codegen.dart:564: compiler.cancel(reason, instruction:node);
On 2012/02/14 16:08:02, floitsch wrote:
> space after instruction:

Done.