chrome/browser/ui/views/extensions/extension_dialog_observer.h - Issue 9360005: Handle termination/crashes of an extension hosted in the ExtensionDialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog_observer.h

Issue 9360005: Handle termination/crashes of an extension hosted in the ExtensionDialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/component_loader.cc ('K') | « chrome/browser/ui/views/extensions/extension_dialog.cc ('k') | chrome/browser/ui/views/select_file_dialog_extension.h » ('j') | chrome/browser/ui/views/select_file_dialog_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_dialog_observer.h

diff --git a/chrome/browser/ui/views/extensions/extension_dialog_observer.h b/chrome/browser/ui/views/extensions/extension_dialog_observer.h

index aeb79807c900830b47559eb94dae8df4abc4dd15..7117dd5381794e9f762efa8396b8d11ce79dbedb 100644

--- a/chrome/browser/ui/views/extensions/extension_dialog_observer.h

+++ b/chrome/browser/ui/views/extensions/extension_dialog_observer.h

@@ -18,6 +18,7 @@ class ExtensionDialogObserver {

// is ref-counted, and thus will be released shortly after

// making this delegate call.

virtual void ExtensionDialogClosing(ExtensionDialog* popup) = 0;

+ virtual void ExtensionDialogTerminated(ExtensionDialog* popup) = 0;

James Cook 2012/02/08 05:32:31 Maybe add a comment indicating when this function

rkc 2012/02/09 00:24:22 Done.

};

#endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_