chrome/browser/ui/views/extensions/extension_dialog_observer.h - Issue 9360005: Handle termination/crashes of an extension hosted in the ExtensionDialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/extension_dialog_observer.h

Issue 9360005: Handle termination/crashes of an extension hosted in the ExtensionDialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/component_loader.cc ('K') | « chrome/browser/ui/views/extensions/extension_dialog.cc ('k') | chrome/browser/ui/views/select_file_dialog_extension.h » ('j') | chrome/browser/ui/views/select_file_dialog_extension.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_

6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_	6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_

7 #pragma once	7 #pragma once

8	8

9 class ExtensionDialog;	9 class ExtensionDialog;

10	10

11 // Observer to ExtensionDialog events.	11 // Observer to ExtensionDialog events.

12 class ExtensionDialogObserver {	12 class ExtensionDialogObserver {

13 public:	13 public:

14 ExtensionDialogObserver();	14 ExtensionDialogObserver();

15 virtual ~ExtensionDialogObserver();	15 virtual ~ExtensionDialogObserver();

16	16

17 // Called when the ExtensionDialog is closing. Note that it	17 // Called when the ExtensionDialog is closing. Note that it

18 // is ref-counted, and thus will be released shortly after	18 // is ref-counted, and thus will be released shortly after

19 // making this delegate call.	19 // making this delegate call.

20 virtual void ExtensionDialogClosing(ExtensionDialog* popup) = 0;	20 virtual void ExtensionDialogClosing(ExtensionDialog* popup) = 0;

	21 virtual void ExtensionDialogTerminated(ExtensionDialog* popup) = 0;
	James Cook 2012/02/08 05:32:31 Maybe add a comment indicating when this function Maybe add a comment indicating when this function will be called? rkc 2012/02/09 00:24:22 Done. Show quoted text On 2012/02/08 05:32:31, James Cook (Chromium) wrote: > Maybe add a comment indicating when this function will be called? Done.
21 };	22 };

22	23

23 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_	24 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_DIALOG_OBSERVER_H_

OLD	NEW