Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: net/base/x509_cert_types.h

Issue 9358080: Properly parse UTF8Strings in certificates on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_cert_types.h
diff --git a/net/base/x509_cert_types.h b/net/base/x509_cert_types.h
index 57d785f1da55ffab23067e9a9804c90997487825..d11092d23d7c9077424191c7303724ee38c9b939 100644
--- a/net/base/x509_cert_types.h
+++ b/net/base/x509_cert_types.h
@@ -51,10 +51,12 @@ struct NET_EXPORT CertPrincipal {
explicit CertPrincipal(const std::string& name);
~CertPrincipal();
-#if defined(OS_MACOSX)
+#if defined(OS_MACOSX) || defined(OS_WIN)
// Parses a BER-format DistinguishedName.
bool ParseDistinguishedName(const void* ber_name_data, size_t length);
+#endif
+#if defined(OS_MACOSX)
// Compare this CertPrincipal with |against|, returning true if they're
// equal enough to be a possible match. This should NOT be used for any
// security relevant decisions.
@@ -66,7 +68,7 @@ struct NET_EXPORT CertPrincipal {
// order: CN, O and OU and returns the first non-empty one found.
std::string GetDisplayName() const;
- // The different attributes for a principal. They may be "".
+ // The different attributes for a principal, stored in UTF-8. They may be "".
// Note that some of them can have several values.
std::string common_name;

Powered by Google App Engine
This is Rietveld 408576698