Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 9358080: Properly parse UTF8Strings in certificates on Windows. (Closed)

Created:
8 years, 10 months ago by Ryan Sleevi
Modified:
8 years, 10 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, kenjibaheux
Visibility:
Public.

Description

Properly parse UTF8Strings in certificates on Windows. BUG=114168 TEST=https://www.verisign.co.jp appears correctly regardless of system locale. Additionally, net_unittests:X509TypesTest* should cover this. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122053

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review feedback #

Patch Set 3 : Update gyp for linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -486 lines) Patch
M crypto/capi_util.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M crypto/capi_util.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M crypto/signature_verifier_win.cc View 1 4 chunks +5 lines, -18 lines 0 comments Download
M net/base/x509_cert_types.h View 2 chunks +4 lines, -2 lines 0 comments Download
D net/base/x509_cert_types_mac_unittest.cc View 1 chunk +0 lines, -341 lines 0 comments Download
A + net/base/x509_cert_types_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A net/base/x509_cert_types_win.cc View 1 1 chunk +139 lines, -0 lines 0 comments Download
M net/base/x509_certificate_win.cc View 1 6 chunks +11 lines, -124 lines 0 comments Download
M net/net.gyp View 1 2 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
wtc: For your review. It's been requested to be M17 mergable. kenji: FYI
8 years, 10 months ago (2012-02-15 00:39:22 UTC) #1
wtc
Patch Set 1 LGTM. Just some nits and questions. Thanks. http://codereview.chromium.org/9358080/diff/1/crypto/capi_util.h File crypto/capi_util.h (right): http://codereview.chromium.org/9358080/diff/1/crypto/capi_util.h#newcode36 ...
8 years, 10 months ago (2012-02-15 01:34:41 UTC) #2
Ryan Sleevi
http://codereview.chromium.org/9358080/diff/1/net/base/x509_cert_types_win.cc File net/base/x509_cert_types_win.cc (right): http://codereview.chromium.org/9358080/diff/1/net/base/x509_cert_types_win.cc#newcode57 net/base/x509_cert_types_win.cc:57: wide_name.resize(chars_written - 1); On 2012/02/15 01:34:41, wtc wrote: > ...
8 years, 10 months ago (2012-02-15 02:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9358080/5001
8 years, 10 months ago (2012-02-15 02:37:12 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 02:37:17 UTC) #5
Presubmit check for 9358080-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/base/x509_cert_types_unittest.cc, line 21, 97 chars \
  net/base/x509_cert_types_unittest.cc, line 45, 85 chars \
  net/base/x509_cert_types_unittest.cc, line 49, 83 chars \
  net/base/x509_cert_types_unittest.cc, line 87, 96 chars \
  net/base/x509_cert_types_unittest.cc, line 109, 105 chars

New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    net/base/x509_cert_types_win.cc:50

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698