Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.gypi

Issue 9355030: Build nacl plugin with normal chromium warning levels (higher levels), (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: var setting should have been outside of target_defaults. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/plugin.gypi
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.gypi b/ppapi/native_client/src/trusted/plugin/plugin.gypi
index e52b8bb18e52783fbbc19fd588889c4d6766a6f9..093cebf1a77bf68fda1de79117e78005da74cd9c 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.gypi
+++ b/ppapi/native_client/src/trusted/plugin/plugin.gypi
@@ -1,9 +1,10 @@
-# Copyright (c) 2011 The Native Client Authors. All rights reserved.
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'variables': {
+ 'chromium_code': 1, # Use higher warning level.
'common_sources': [
'file_downloader.cc',
'json_manifest.cc',
@@ -52,6 +53,9 @@
'cflags': [
'-Wno-long-long',
],
+ 'cflags!': [
+ '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.
+ ],
'conditions': [
['asan!=1', {
'ldflags': [
@@ -77,6 +81,9 @@
'cflags': [
'-Wno-long-long',
],
+ 'cflags!': [
+ '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.
+ ],
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/Carbon.framework',
« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698