Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp

Issue 9355030: Build nacl plugin with normal chromium warning levels (higher levels), (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: var setting should have been outside of target_defaults. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/plugin.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp b/ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp
index 733a35c5dc09ed596fe7a8ebab655a73b36df362..443fbaa9a295c126c586790d7dea83c1c950459c 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp
+++ b/ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp
@@ -3,9 +3,26 @@
# found in the LICENSE file.
{
+ 'variables': {
+ 'chromium_code': 1, # Use higher warning level.
+ },
'includes': [
'../../../../../native_client/build/common.gypi',
],
+ 'target_defaults': {
+ 'conditions': [
+ ['OS=="linux"', {
+ 'cflags!': [
+ '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.
+ ],
+ }],
+ ['OS=="mac"', {
+ 'cflags!': [
+ '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.
+ ],
+ }],
+ ],
+ },
'targets': [
{
'target_name': 'nacl_ppapi_browser',
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/plugin.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698