Build nacl plugin with normal chromium warning levels (higher levels),

Build nacl plugin with normal chromium warning levels (higher levels).

BUG= none
TEST= compile / run nacl_integration


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127643

[jvoung - send to chromium..., 2012-02-19 03:14:07]

hmm... will put this on hold until further investigation.

It does add warnings about format strings. However, nacl's build/common.gypi
explicitly sets 'chromium_code' to 0, which might be a bit contradicting.

Also, -Werror seems to disappear from the src/trusted/plugin makefile (yet it is
there in the src/shared/ppapi_proxy makefile) for strange reasons (even if you
try to forcibly add it to cflags)?!?!?!

[jvoung - send to chromium..., 2012-02-28 01:11:41]

PTAL.  Didn't actually need to set in nacl repo (issues with the gyp conventions
of filtering out "linux" on non-linux systems, etc.) -- anyway the nacl
common.gypi was only providing a default, which we override here.

[sehr (please use chromium), 2012-03-13 15:28:26]

On 2012/02/28 01:11:41, jvoung wrote:
> PTAL.  Didn't actually need to set in nacl repo (issues with the gyp
conventions
> of filtering out "linux" on non-linux systems, etc.) -- anyway the nacl
> common.gypi was only providing a default, which we override here.

LGTM.

[commit-bot: I haz the power, 2012-03-20 03:09:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@google.com/9355030/6001

[commit-bot: I haz the power, 2012-03-20 05:04:17]

Change committed as 127643