Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 9355030: Build nacl plugin with normal chromium warning levels (higher levels), (Closed)

Created:
8 years, 10 months ago by jvoung - send to chromium...
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Build nacl plugin with normal chromium warning levels (higher levels). BUG= none TEST= compile / run nacl_integration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127643

Patch Set 1 #

Patch Set 2 : var setting should have been outside of target_defaults. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 1 chunk +17 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gypi View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung - send to chromium...
8 years, 10 months ago (2012-02-19 02:01:29 UTC) #1
jvoung - send to chromium...
hmm... will put this on hold until further investigation. It does add warnings about format ...
8 years, 10 months ago (2012-02-19 03:14:07 UTC) #2
jvoung - send to chromium...
PTAL. Didn't actually need to set in nacl repo (issues with the gyp conventions of ...
8 years, 10 months ago (2012-02-28 01:11:41 UTC) #3
sehr (please use chromium)
On 2012/02/28 01:11:41, jvoung wrote: > PTAL. Didn't actually need to set in nacl repo ...
8 years, 9 months ago (2012-03-13 15:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@google.com/9355030/6001
8 years, 9 months ago (2012-03-20 03:09:05 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 05:04:17 UTC) #6
Change committed as 127643

Powered by Google App Engine
This is Rietveld 408576698