Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9350056: Tests triage: language (Closed)

Created:
8 years, 10 months ago by scheglov
Modified:
8 years, 10 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tests triage: language R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4266

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -92 lines) Patch
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/language/language.status View 4 chunks +56 lines, -92 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
8 years, 10 months ago (2012-02-13 22:40:40 UTC) #1
zundel
https://chromiumcodereview.appspot.com/9350056/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9350056/diff/1/tests/language/language.status#newcode140 tests/language/language.status:140: CTConstTest: Pass Are the issues previously listed still valid? ...
8 years, 10 months ago (2012-02-13 22:51:09 UTC) #2
scheglov
https://chromiumcodereview.appspot.com/9350056/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9350056/diff/1/tests/language/language.status#newcode140 tests/language/language.status:140: CTConstTest: Pass On 2012/02/13 22:51:09, zundel wrote: > Are ...
8 years, 10 months ago (2012-02-14 16:37:37 UTC) #3
zundel
8 years, 10 months ago (2012-02-15 13:26:46 UTC) #4
lgtm

http://codereview.chromium.org/9350056/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/9350056/diff/1/tests/language/language.status#...
tests/language/language.status:140: CTConstTest: Pass
OK, I see now.  If a line is marked 'Pass' and the bug is related to code
generation and now closed, we can just remove that line from the status file.
Feel free to do it in this or a followon change.

On 2012/02/14 16:37:37, scheglov wrote:
> On 2012/02/13 22:51:09, zundel wrote:
> > Are the issues previously listed still valid?  If so, let's not lose the
> > comments with the issue number on this update.   If the problem is different
> > from what's described in the issue, then this is fine, as long at you closed
> any
> > issues that are dependent only on dartc code generation.
> 
> Yes, I've checked all bugs in comments and closed them only if they are for
code
> generation. If we still should have some warning during analysis, I've opened
> new issue.

Powered by Google App Engine
This is Rietveld 408576698