Move handling of debug urls like chrome://crash, chrome://gpuclean to content. These are for test...

Move handling of debug urls like chrome://crash, chrome://gpuclean to content. These are for testing the content layer, so they belong there. This allows us to hide GpuProcessHostUIShim from chrome.

I cleaned up the about_handler.* files which were overly complicated. I also was able to remove a method from ContentBrowserClient.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120891

[jam, 2012-02-07 23:18:22]

rerouting to Avi

[Elliot Glaysher, 2012-02-08 01:06:34]

lgtm

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.cc (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.cc:23: namespace chrome {
I guess we already have chrome all over here, huh?

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.h (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.h:44: CONTENT_EXPORT extern const char
kChromeUIBrowserCrashHost[];
As long as you don't mind "chrome" in these names...

[jam, 2012-02-08 01:20:14]

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.cc (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.cc:23: namespace chrome {
On 2012/02/08 01:06:35, Elliot Glaysher wrote:
> I guess we already have chrome all over here, huh?

yeah we need to rename this namespace to chrome. i'll add it to my list of todos
and add a comment in the header

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.h (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.h:44: CONTENT_EXPORT extern const char
kChromeUIBrowserCrashHost[];
On 2012/02/08 01:06:35, Elliot Glaysher wrote:
> As long as you don't mind "chrome" in these names...

i was a bit hesitant. these urls are testing content level stuff. but, right now
chrome only supports these urls when they're in the "chrome" scheme. i'm not
sure we want to expose the chrome/content split in the UI. so perhaps we can
have a way for the embedder to specify the scheme used for the test urls?

[Avi (use Gerrit), 2012-02-08 03:46:41]

http://codereview.chromium.org/9349010/diff/177/content/browser/tab_contents/...
File content/browser/tab_contents/debug_urls.cc (right):

http://codereview.chromium.org/9349010/diff/177/content/browser/tab_contents/...
content/browser/tab_contents/debug_urls.cc:19: // Handle URLs to crash the
browser or wreck the gpu process.
Move to be function comment rather than a comment on the code here.

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.cc (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.cc:55: 
Why do some of these end with a slash and some do not?

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
File content/public/common/url_constants.h (right):

http://codereview.chromium.org/9349010/diff/177/content/public/common/url_con...
content/public/common/url_constants.h:44: CONTENT_EXPORT extern const char
kChromeUIBrowserCrashHost[];
Sure, though the scheme used doesn't affect what constant names we use here.