Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: webkit/dom_storage/dom_storage_task_runner.h

Issue 9347056: Fix up SequencedWorkerPool in preparation for making it a TaskRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/dom_storage/dom_storage_session.cc ('k') | webkit/dom_storage/dom_storage_task_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/dom_storage/dom_storage_task_runner.h
diff --git a/webkit/dom_storage/dom_storage_task_runner.h b/webkit/dom_storage/dom_storage_task_runner.h
index a5c09b1cf73d667b50936fa5edfb95b86cf1f122..6384d9eea3492a6ef56a8091b516798cefaabaca 100644
--- a/webkit/dom_storage/dom_storage_task_runner.h
+++ b/webkit/dom_storage/dom_storage_task_runner.h
@@ -8,6 +8,7 @@
#include "base/memory/ref_counted.h"
#include "base/threading/sequenced_worker_pool.h"
+#include "base/time.h"
namespace base {
class MessageLoopProxy;
@@ -21,7 +22,8 @@ namespace dom_storage {
class DomStorageTaskRunner
: public base::RefCountedThreadSafe<DomStorageTaskRunner> {
public:
- explicit DomStorageTaskRunner(base::MessageLoopProxy* message_loop);
+ explicit DomStorageTaskRunner(
+ const scoped_refptr<base::MessageLoopProxy>& message_loop);
virtual ~DomStorageTaskRunner();
// Schedules a task to be run immediately.
@@ -36,7 +38,7 @@ class DomStorageTaskRunner
base::TimeDelta delay);
protected:
- scoped_refptr<base::MessageLoopProxy> message_loop_;
+ const scoped_refptr<base::MessageLoopProxy> message_loop_;
};
// A derived class that utlizes the SequenceWorkerPool under a
@@ -45,8 +47,8 @@ class DomStorageTaskRunner
class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner {
public:
DomStorageWorkerPoolTaskRunner(
- base::SequencedWorkerPool* sequenced_worker_pool,
- base::MessageLoopProxy* delayed_task_loop);
+ const scoped_refptr<base::SequencedWorkerPool>& sequenced_worker_pool,
+ const scoped_refptr<base::MessageLoopProxy>& delayed_task_loop);
michaeln 2012/02/23 03:55:25 Has our style been changed to require this techniq
akalin 2012/02/23 22:22:30 Done.
virtual ~DomStorageWorkerPoolTaskRunner();
// Schedules a sequenced worker task to be run immediately.
@@ -61,7 +63,7 @@ class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner {
base::TimeDelta delay) OVERRIDE;
private:
- base::SequencedWorkerPool* sequenced_worker_pool_; // not owned
+ const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
base::SequencedWorkerPool::SequenceToken sequence_token_;
};
« no previous file with comments | « webkit/dom_storage/dom_storage_session.cc ('k') | webkit/dom_storage/dom_storage_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698