Fix up SequencedWorkerPool in preparation for making it a TaskRunner

webkit/dom_storage/dom_storage_task_runner.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_
 #define WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include "base/time.h"
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace dom_storage {
 
 // Tasks must run serially with respect to one another, but may
 // execute on different OS threads. The base class is implemented
 // in terms of a MessageLoopProxy for use in testing.
 class DomStorageTaskRunner
     : public base::RefCountedThreadSafe<DomStorageTaskRunner> {
  public:
-  explicit DomStorageTaskRunner(base::MessageLoopProxy* message_loop);
+  explicit DomStorageTaskRunner(
+      const scoped_refptr<base::MessageLoopProxy>& message_loop);
   virtual ~DomStorageTaskRunner();
 
   // Schedules a task to be run immediately.
   virtual void PostTask(
       const tracked_objects::Location& from_here,
       const base::Closure& task);
 
   // Schedules a task to be run after a delay.
   virtual void PostDelayedTask(
       const tracked_objects::Location& from_here,
       const base::Closure& task,
       base::TimeDelta delay);
 
  protected:
-  scoped_refptr<base::MessageLoopProxy> message_loop_;
+  const scoped_refptr<base::MessageLoopProxy> message_loop_;
 };
 
 // A derived class that utlizes the SequenceWorkerPool under a
 // dom_storage specific SequenceToken. The MessageLoopProxy
 // is used to delay scheduling on the worker pool.
 class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner {
  public:
   DomStorageWorkerPoolTaskRunner(
-      base::SequencedWorkerPool* sequenced_worker_pool,
-      base::MessageLoopProxy* delayed_task_loop);
+      const scoped_refptr<base::SequencedWorkerPool>& sequenced_worker_pool,
+      const scoped_refptr<base::MessageLoopProxy>& delayed_task_loop);

[michaeln, 2012/02/23 03:55:25]

Has our style been changed to require this technique of passing refs to
refcounted objects? Unless this is specificially required, i'd prefer the simple
ptr types to remain here.

[akalin, 2012/02/23 22:22:30]

Done.

   virtual ~DomStorageWorkerPoolTaskRunner();
 
   // Schedules a sequenced worker task to be run immediately.
   virtual void PostTask(
       const tracked_objects::Location& from_here,
       const base::Closure& task) OVERRIDE;
 
   // Schedules a sequenced worker task to be run after a delay.
   virtual void PostDelayedTask(
       const tracked_objects::Location& from_here,
       const base::Closure& task,
       base::TimeDelta delay) OVERRIDE;
 
  private:
-  base::SequencedWorkerPool* sequenced_worker_pool_;  // not owned
+  const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
   base::SequencedWorkerPool::SequenceToken sequence_token_;
 };
 
 }  // namespace dom_storage
 
 #endif  // WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_