Add fullscreen state support for chrome.windows

chrome/browser/extensions/extension_tabs_module.cc

Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 62e6c18be2dcf10e0a3a56f53b933a08ddfc398d..2c4c5534b9f5bf2defe90a896759f2f3eaf72ced 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -595,12 +595,18 @@ bool UpdateWindowFunction::RunImpl() {
       show_state = ui::SHOW_STATE_MINIMIZED;
     } else if (state_str == keys::kShowStateValueMaximized) {
       show_state = ui::SHOW_STATE_MAXIMIZED;
+    } else if (state_str == keys::kShowStateValueFullscreen) {
+      show_state = ui::SHOW_STATE_FULLSCREEN;
     } else {
       error_ = keys::kInvalidWindowStateError;
       return false;
     }
   }
 
+  if (browser->window()->IsFullscreen() &&
+      show_state != ui::SHOW_STATE_FULLSCREEN)
+    browser->window()->ExitFullscreen();
+
   switch (show_state) {
     case ui::SHOW_STATE_MINIMIZED:
       browser->window()->Minimize();
@@ -608,6 +614,12 @@ bool UpdateWindowFunction::RunImpl() {
     case ui::SHOW_STATE_MAXIMIZED:
       browser->window()->Maximize();
       break;
+    case ui::SHOW_STATE_FULLSCREEN:
+      if (browser->window()->IsMinimized() || browser->window()->IsMaximized())
+        browser->window()->Restore();
+      browser->window()->EnterFullscreen(

[Mihai Parparita -not on Chrome, 2012/02/06 22:31:34]

Aaron: should the ability to go fullscreen be tied to a permission (even if we
don't prompt for it)?

+          GURL(), FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION);

[Mihai Parparita -not on Chrome, 2012/02/06 22:31:34]

This ends up displaying the "You have gone full screen" message, which doesn't
seem quite right, since it wasn't necessarily the user that triggered the
extension calling chrome.windows.update. Perhaps there should be a separate
message that mentions that the extension/app triggered full screen?

[hashimoto, 2012/02/07 02:16:00]

Done.
The message is now "<Extension Name> triggered full screen."

+      break;
     case ui::SHOW_STATE_NORMAL:
       browser->window()->Restore();
       break;
@@ -654,7 +666,8 @@ bool UpdateWindowFunction::RunImpl() {
 
   if (set_bounds) {
     if (show_state == ui::SHOW_STATE_MINIMIZED ||
-        show_state == ui::SHOW_STATE_MAXIMIZED) {
+        show_state == ui::SHOW_STATE_MAXIMIZED ||
+        show_state == ui::SHOW_STATE_FULLSCREEN) {
       error_ = keys::kInvalidWindowStateError;
       return false;
     }
@@ -672,7 +685,8 @@ bool UpdateWindowFunction::RunImpl() {
       }
       browser->window()->Activate();
     } else {
-      if (show_state == ui::SHOW_STATE_MAXIMIZED) {
+      if (show_state == ui::SHOW_STATE_MAXIMIZED ||
+          show_state == ui::SHOW_STATE_FULLSCREEN) {
         error_ = keys::kInvalidWindowStateError;
         return false;
       }