Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4516)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 9328037: Add fullscreen state support for chrome.windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index a2efc9e847b53bace6c95268cecc4316317991a5..ac8f712da08d4ee7b6eba63fb734a66976988d19 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -69,7 +69,9 @@ std::string ExtensionTabUtil::GetWindowShowStateText(const Browser* browser) {
BrowserWindow* window = browser->window();
if (window->IsMinimized())
return keys::kShowStateValueMinimized;
- if (window->IsMaximized() || window->IsFullscreen())
+ if (window->IsFullscreen())
+ return keys::kShowStateValueFullscreen;
Mihai Parparita -not on Chrome 2012/02/06 22:31:34 Aaron: are we worried about this change not being
jennb 2012/02/06 23:34:25 Panels cannot go fullscreen so there's no backward
+ if (window->IsMaximized())
return keys::kShowStateValueMaximized;
return keys::kShowStateValueNormal;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module.cc » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698