Add fullscreen state support for chrome.windows

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 51 matching lines @@
   if (browser->is_app())
     return keys::kWindowTypeValueApp;
   return keys::kWindowTypeValueNormal;
 }
 
 // Return the state name for a browser window state.
 std::string ExtensionTabUtil::GetWindowShowStateText(const Browser* browser) {
   BrowserWindow* window = browser->window();
   if (window->IsMinimized())
     return keys::kShowStateValueMinimized;
-  if (window->IsMaximized() || window->IsFullscreen())
+  if (window->IsFullscreen())
+    return keys::kShowStateValueFullscreen;

[Mihai Parparita -not on Chrome, 2012/02/06 22:31:34]

Aaron: are we worried about this change not being backwards compatible (current
extensions would not be checking for the "fullscreen" enum value)? IMO, it seems
unlikely to break anything; the state property was added pretty recently
(http://crrev.com/111071) for Panels/Quasar, and we can check with them to see
if this breaks anything.

[jennb, 2012/02/06 23:34:25]

Panels cannot go fullscreen so there's no backwards compatibility issues on our
end.

+  if (window->IsMaximized())
     return keys::kShowStateValueMaximized;
   return keys::kShowStateValueNormal;
 }
 
 DictionaryValue* ExtensionTabUtil::CreateTabValue(const WebContents* contents) {
   // Find the tab strip and index of this guy.
   TabStripModel* tab_strip = NULL;
   int tab_index;
   if (ExtensionTabUtil::GetTabStripModel(contents, &tab_strip, &tab_index))
     return ExtensionTabUtil::CreateTabValue(contents, tab_strip, tab_index);
@@ skipping 161 matching lines @@
             *contents = target_contents;
           if (tab_index)
             *tab_index = i;
           return true;
         }
       }
     }
   }
   return false;
 }