Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 9323023: Support optional PNaCl download by bots. (Closed)

Created:
8 years, 10 months ago by noelallen1
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Support optional PNaCl download by bots. Adds and optional download for bots triggered by environment variable. This download will only happen on SDK bots until we switch to PNaCl. BUG=112929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120918

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/download_nacl_toolchains.py View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
We'll need to compute starting hashes, and what version of pnacl you'll want to start ...
8 years, 10 months ago (2012-02-03 01:55:10 UTC) #1
sehr (please use chromium)
lgtm
8 years, 10 months ago (2012-02-05 00:29:18 UTC) #2
noelallen1
8 years, 10 months ago (2012-02-07 00:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/9323023/10001
8 years, 10 months ago (2012-02-08 00:23:41 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-08 02:28:53 UTC) #5
Change committed as 120918

Powered by Google App Engine
This is Rietveld 408576698