Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: build/download_nacl_toolchains.py

Issue 9323023: Support optional PNaCl download by bots. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_nacl_toolchains.py
===================================================================
--- build/download_nacl_toolchains.py (revision 120871)
+++ build/download_nacl_toolchains.py (working copy)
@@ -25,9 +25,24 @@
sys.exit(0)
sys.path.insert(0, nacl_build_dir)
import download_toolchains
+
+ # TODO (robertm): Finish getting PNaCl ready for prime time.
+ # BUG:
+ # We remove this --optional-pnacl argument, and instead replace it with
+ # --no-pnacl for most cases. However, if the bot name is the pnacl_sdk
+ # bot then we will go ahead and download it. This prevents increasing the
+ # gclient sync time for developers, or standard Chrome bots.
+ if '--optional-pnacl' in args:
+ args.remove('--optional-pnacl')
+ if os.environ.get('BUILDBOT_BUILDERNAME', '') == 'linux_pnacl_sdk':
+ print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
+ else:
+ args.append('--no-pnacl')
+
download_toolchains.Main(args)
return 0
if __name__ == '__main__':
sys.exit(Main(sys.argv[1:]))
+
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698