Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 9317033: Tighten the check for detecting misbehaving proxies in device management requests. (Closed)

Created:
8 years, 10 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 10 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Tighten the check for detecting misbehaving proxies in device management requests. BUG=chromium-os:20775 TEST=Using a misconfigured-proxy but with direct connections working, registering without a serial shows the serial number invalid error instead of network error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/policy/device_management_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Please review.
8 years, 10 months ago (2012-02-01 14:28:38 UTC) #1
Joao da Silva
lgtm
8 years, 10 months ago (2012-02-01 14:39:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9317033/1
8 years, 10 months ago (2012-02-01 15:56:48 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 17:12:51 UTC) #4
Change committed as 120073

Powered by Google App Engine
This is Rietveld 408576698