chrome/browser/policy/device_management_service.cc - Issue 9317033: Tighten the check for detecting misbehaving proxies in device management requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/device_management_service.cc

Issue 9317033: Tighten the check for detecting misbehaving proxies in device management requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/device_management_service.cc

diff --git a/chrome/browser/policy/device_management_service.cc b/chrome/browser/policy/device_management_service.cc

index 1b93c6cf6ca46e681ea1c13e0a3f20237653bed2..cfb4b56b622036dbe3be37a9552a9b0366ef102a 100644

--- a/chrome/browser/policy/device_management_service.cc

+++ b/chrome/browser/policy/device_management_service.cc

@@ -540,6 +540,7 @@ void DeviceManagementService::OnURLFetchComplete(

LOG(WARNING) << "Proxy failed while contacting dmserver.";

retry = true;

} else if (source->GetStatus().is_success() &&

+ source->GetResponseCode() == kSuccess &&

source->WasFetchedViaProxy() &&

!IsProtobufMimeType(source)) {

// The proxy server can be misconfigured but pointing to an existing

« no previous file with comments | « no previous file | no next file » | no next file with comments »