content/browser/renderer_host/render_message_filter.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Shift recording of UMA to before initiation in all cases. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_util.cc ('K') | « content/browser/download/drag_download_file.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_message_filter.cc

diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc

index 6afda7bdeec92ab6294de57480be930e802f39cf..e8a956af9471b11139b5baf30f3f2a70e24cee95 100644

--- a/content/browser/renderer_host/render_message_filter.cc

+++ b/content/browser/renderer_host/render_message_filter.cc

@@ -688,6 +688,7 @@ void RenderMessageFilter::OnDownloadUrl(const IPC::Message& message,

scoped_ptr<net::URLRequest> request(

new net::URLRequest(url, resource_dispatcher_host_));

request->set_referrer(referrer.spec());

+ download_stats::RecordDownloadSource(download_stats::INITIATED_BY_RENDERER);

resource_dispatcher_host_->BeginDownload(

request.Pass(),

false,

@@ -696,8 +697,6 @@ void RenderMessageFilter::OnDownloadUrl(const IPC::Message& message,

render_process_id_,

message.routing_id(),

resource_context_);

- download_stats::RecordDownloadCount(

- download_stats::INITIATED_BY_RENDERER_COUNT);

}

void RenderMessageFilter::OnCheckNotificationPermission(

« chrome/browser/download/download_util.cc ('K') | « content/browser/download/drag_download_file.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »