content/browser/download/drag_download_file.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/drag_download_file.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Shift recording of UMA to before initiation in all cases. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_util.cc ('K') | « content/browser/download/download_stats.cc ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/drag_download_file.cc

diff --git a/content/browser/download/drag_download_file.cc b/content/browser/download/drag_download_file.cc

index 7cc13c455a0ec652172d7abc142155e4be2b0fd6..788b2ba2461d511a67c376701a79c6959200c4e9 100644

--- a/content/browser/download/drag_download_file.cc

+++ b/content/browser/download/drag_download_file.cc

@@ -133,14 +133,14 @@ void DragDownloadFile::InitiateDownload() {

save_info.file_path = file_path_;

save_info.file_stream = file_stream_;

+ download_stats::RecordDownloadSource(

+ download_stats::INITIATED_BY_DRAG_N_DROP);

download_manager_->DownloadUrl(url_,

referrer_,

referrer_encoding_,

false,

save_info,

web_contents_);

- download_stats::RecordDownloadCount(

- download_stats::INITIATED_BY_DRAG_N_DROP_COUNT);

}

void DragDownloadFile::DownloadCompleted(bool is_successful) {