chrome/browser/tab_contents/render_view_context_menu.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_throttling_resource_handler.cc ('K') | « chrome/browser/extensions/webstore_installer.cc ('k') | content/browser/download/download_stats.h » ('j') | content/browser/download/download_stats.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc

index e24f65e242729009b70710cbc26008720c68800f..41ab4ba3c0160e01986179f58bf3a34e2126110d 100644

--- a/chrome/browser/tab_contents/render_view_context_menu.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu.cc

@@ -1487,8 +1487,8 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

case IDC_CONTENT_CONTEXT_SAVEAVAS:

case IDC_CONTENT_CONTEXT_SAVEIMAGEAS:

case IDC_CONTENT_CONTEXT_SAVELINKAS: {

- download_util::RecordDownloadCount(

- download_util::INITIATED_BY_CONTEXT_MENU_COUNT);

+ download_util::RecordDownloadSource(

+ download_util::INITIATED_BY_CONTEXT_MENU);

const GURL& referrer =

params_.frame_url.is_empty() ? params_.page_url : params_.frame_url;

const GURL& url =