chrome/browser/download/download_throttling_resource_handler.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_throttling_resource_handler.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/imageburner/burn_manager.cc ('k') | chrome/browser/download/download_util.h » ('j') | content/browser/download/download_stats.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_throttling_resource_handler.cc

diff --git a/chrome/browser/download/download_throttling_resource_handler.cc b/chrome/browser/download/download_throttling_resource_handler.cc

index 85bc6e19cbaf39fb247f93d8ee8c385c4db1b183..38e7ab2e1ce6bad71e7c2dd3f293cbc55cfdcb1b 100644

--- a/chrome/browser/download/download_throttling_resource_handler.cc

+++ b/chrome/browser/download/download_throttling_resource_handler.cc

@@ -134,8 +134,7 @@ void DownloadThrottlingResourceHandler::OnRequestClosed() {

}

void DownloadThrottlingResourceHandler::ContinueDownload(bool allow) {

- download_util::RecordDownloadCount(

- download_util::INITIATED_BY_NAVIGATION_COUNT);

+ download_util::RecordDownloadSource(download_util::INITIATED_BY_NAVIGATION);

cbentzel 2012/02/06 19:57:29 Should this be done here or at the BufferedResourc

Randy Smith (Not in Mondays) 2012/02/07 18:20:18 Depends how we're thinking of the stats. I'm more

if (request_closed_)

return;