Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/resources/options2/language_list.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/language_list.js
diff --git a/chrome/browser/resources/options2/language_list.js b/chrome/browser/resources/options2/language_list.js
index 3cbcb752a91acfa93e8ea97d975b8732fbc0df99..4b4e81f797c179cb42562f08234b4b6cbd4fccb3 100644
--- a/chrome/browser/resources/options2/language_list.js
+++ b/chrome/browser/resources/options2/language_list.js
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -230,7 +230,7 @@ cr.define('options', function() {
* @param {Event} e The drop or dragover event.
* @private
*/
- getTargetFromDropEvent_ : function(e) {
+ getTargetFromDropEvent_: function(e) {
var target = e.target;
// e.target may be an inner element of the list item
while (target != null && !(target instanceof ListItem)) {
@@ -321,7 +321,7 @@ cr.define('options', function() {
* @param {Event} e The dragleave event
* @private
*/
- handleDragLeave_ : function(e) {
+ handleDragLeave_: function(e) {
this.hideDropMarker_();
},
@@ -331,15 +331,15 @@ cr.define('options', function() {
* @param {string} pos 'below' or 'above'
* @private
*/
- showDropMarker_ : function(target, pos) {
+ showDropMarker_: function(target, pos) {
window.clearTimeout(this.hideDropMarkerTimer_);
var marker = $('language-options-list-dropmarker');
var rect = target.getBoundingClientRect();
var markerHeight = 8;
if (pos == 'above') {
- marker.style.top = (rect.top - markerHeight/2) + 'px';
+ marker.style.top = (rect.top - markerHeight / 2) + 'px';
} else {
- marker.style.top = (rect.bottom - markerHeight/2) + 'px';
+ marker.style.top = (rect.bottom - markerHeight / 2) + 'px';
}
marker.style.width = rect.width + 'px';
marker.style.left = rect.left + 'px';
@@ -350,7 +350,7 @@ cr.define('options', function() {
* Hides the drop marker.
* @private
*/
- hideDropMarker_ : function() {
+ hideDropMarker_: function() {
// Hide the marker in a timeout to reduce flickering as we move between
// valid drop targets.
window.clearTimeout(this.hideDropMarkerTimer_);
@@ -407,7 +407,7 @@ cr.define('options', function() {
this.selectionModel.selectedIndex = originalSelectedIndex;
// The lead index should be updated too.
this.selectionModel.leadIndex = originalSelectedIndex;
- } else if (this.dataModel.length > 0){
+ } else if (this.dataModel.length > 0) {
// Otherwise, select the first item if it's not empty.
// Note that ListSingleSelectionModel won't select an item
// automatically, hence we manually select the first item here.
« no previous file with comments | « chrome/browser/resources/options2/intents_list.js ('k') | chrome/browser/resources/options2/language_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698