Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/browser/resources/options2/intents_list.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/intents_list.js
diff --git a/chrome/browser/resources/options2/intents_list.js b/chrome/browser/resources/options2/intents_list.js
index e2dc21e65414bb42d96bb5d413aed8935e3f8777..12bb6e22f49d5f4e7d4195733190cd99d7a4f9c1 100644
--- a/chrome/browser/resources/options2/intents_list.js
+++ b/chrome/browser/resources/options2/intents_list.js
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -237,8 +237,8 @@ cr.define('options', function() {
* Set the currently selected intents node ("intents bubble") index to
* @{code itemIndex}, unselecting any previously selected node first.
* @param {number} itemIndex The index to set as the selected index.
- * TODO: KILL THIS
*/
+ // TODO: KILL THIS
set selectedIndex(itemIndex) {
// Get the list index up front before we change anything.
var index = this.list.getIndexOfListItem(this);
@@ -377,13 +377,7 @@ cr.define('options', function() {
var divTypes = item.ownerDocument.createElement('div');
divTypes.className = 'intents-item-types';
- var text = "";
- for (var i = 0; i < this.data.types.length; ++i) {
- if (text != "")
- text += ", ";
- text += this.data.types[i];
- }
- divTypes.textContent = text;
+ divTypes.textContent = this.data.types.join(', ');
div.appendChild(divTypes);
var divUrl = item.ownerDocument.createElement('div');
« no previous file with comments | « chrome/browser/resources/options2/inline_editable_list.js ('k') | chrome/browser/resources/options2/language_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698