Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 93155: Capture Mozilla's codesighs, for use in executable sizing.... (Closed)

Created:
11 years, 8 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Capture Mozilla's codesighs, for use in executable sizing. Vanilla code, no changes, except for the addition of: * LICENSE, copied from elsewhere in the Mozilla tree; * README.chromium, documenting what's going on. * codesighs.gyp, for building with the rest of Chromium. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8319 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/codesighs/LICENSE View 1 chunk +567 lines, -0 lines 0 comments Download
A third_party/codesighs/Makefile.in View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/codesighs/README.chromium View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/codesighs/autosummary.unix.bash View 1 chunk +250 lines, -0 lines 0 comments Download
A third_party/codesighs/autosummary.win.bash View 1 chunk +211 lines, -0 lines 0 comments Download
A third_party/codesighs/basesummary.unix.bash View 1 chunk +254 lines, -0 lines 0 comments Download
A third_party/codesighs/basesummary.win.bash View 1 chunk +224 lines, -0 lines 0 comments Download
A third_party/codesighs/codesighs.c View 1 chunk +1075 lines, -0 lines 0 comments Download
A third_party/codesighs/codesighs.gyp View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/codesighs/maptsvdifftool.c View 1 chunk +1311 lines, -0 lines 0 comments Download
A third_party/codesighs/msdump2symdb.c View 1 chunk +1090 lines, -0 lines 0 comments Download
A third_party/codesighs/msmap.h View 1 chunk +149 lines, -0 lines 0 comments Download
A third_party/codesighs/msmap2tsv.c View 1 chunk +2237 lines, -0 lines 0 comments Download
A third_party/codesighs/nm2tsv.c View 1 chunk +505 lines, -0 lines 0 comments Download
A third_party/codesighs/nm_wrap_osx.pl View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/codesighs/readelf_wrap.pl View 1 chunk +192 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
11 years, 8 months ago (2009-04-24 22:07:19 UTC) #1
Mark Larson
OK, looks fine.
11 years, 8 months ago (2009-04-24 23:11:16 UTC) #2
darin (slow to review)
LGTM
11 years, 8 months ago (2009-04-25 05:50:11 UTC) #3
M-A Ruel
11 years, 8 months ago (2009-04-27 18:10:39 UTC) #4
On 2009/04/25 05:50:11, darin wrote:
> LGTM

This change requires settings svn:ignore on third_party/codesighs/.

codesighs.scons
codesighs.sln
codesighs.vcproj
codesighs.xcodeproj
codesighs_main.scons
maptsvdifftool.scons
maptsvdifftool.vcproj
msdump2symdb.vcproj
msmap2tsv.vcproj
nm2tsv.scons
SConstruct

Checked-in as revision 14624.

Otherwise the try slaves suffer a lot. I'm starting to wonder if we should put
the generated files in the output directory, as you were doing before because it
currently increases the burden and breaks the "a build doesn't modify the src
directory" non-written rule.

Powered by Google App Engine
This is Rietveld 408576698