Issue 93142: Checkbox/RadioButton labels have to reserve space for the focus rects, even i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93142: Checkbox/RadioButton labels have to reserve space for the focus rects, even i... (Closed)

Created:
11 years, 8 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Checkbox/RadioButton labels have to reserve space for the focus rects, even if they're not actively being painted as focused, otherwise layout breaks badly. http://crbug.com/10958 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14464

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1 line)			Patch
M	chrome/views/controls/button/checkbox.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/views/controls/label.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/views/controls/label.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM