Issue 9310066: Generate a resolution error if a unary + is used for something other than numbers.

Issue 9310066: Generate a resolution error if a unary + is used for something other than numbers. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, floitsch, kasperl, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Generate a resolution error if a unary + is used for something other than numbers. Committed: https://code.google.com/p/dart/source/detail?r=3885

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
M	frog/leg/resolver.dart	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	frog/leg/ssa/builder.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/tree/nodes.dart	View	1 2	1 chunk	+4 lines, -6 lines	0 comments	Download
M	frog/leg/warnings.dart	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	3 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/9310066/diff/8/frog/leg/warnings.dart File frog/leg/warnings.dart (right): https://chromiumcodereview.appspot.com/9310066/diff/8/frog/leg/warnings.dart#newcode88 frog/leg/warnings.dart:88: 'Unary + is only applicable to number literals'); ...

8 years, 10 months ago (2012-02-02 17:01:32 UTC) #2

ngeoffray

Thanks Karl, https://chromiumcodereview.appspot.com/9310066/diff/8/frog/leg/warnings.dart File frog/leg/warnings.dart (right): https://chromiumcodereview.appspot.com/9310066/diff/8/frog/leg/warnings.dart#newcode88 frog/leg/warnings.dart:88: 'Unary + is only applicable to number ...

8 years, 10 months ago (2012-02-02 17:02:22 UTC) #3

ahe

LGTM https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.dart File frog/leg/resolver.dart (right): https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.dart#newcode632 frog/leg/resolver.dart:632: && node.receiver.asLiteralInt() == null === https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.dart#newcode633 frog/leg/resolver.dart:633: && ...

8 years, 10 months ago (2012-02-02 17:43:27 UTC) #4

ngeoffray

8 years, 10 months ago (2012-02-03 08:43:45 UTC) #5

Thanks Peter

https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.da...
frog/leg/resolver.dart:632: && node.receiver.asLiteralInt() == null
On 2012/02/02 17:43:27, ahe wrote:
> ===

Done.

https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.da...
frog/leg/resolver.dart:633: && node.receiver.asLiteralDouble() == null) {
On 2012/02/02 17:43:27, ahe wrote:
> ===

Done.

https://chromiumcodereview.appspot.com/9310066/diff/2006/frog/leg/resolver.da...
frog/leg/resolver.dart:634: error(node, MessageKind.NO_UNARY_ADD);
On 2012/02/02 17:43:27, ahe wrote:
> "expected a literal number"

Done.

https://chromiumcodereview.appspot.com/9310066/diff/2006/tests/language/langu...
File tests/language/language-leg.status (right):

https://chromiumcodereview.appspot.com/9310066/diff/2006/tests/language/langu...
tests/language/language-leg.status:184: LiteralUnaryPlusTest/01: Fail # '+ 1' is
not allowed
On 2012/02/02 17:43:27, ahe wrote:
> Leg fails to reject "+ 1".

Done.

Expand Messages | Collapse Messages