Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9307012: Add Mach ports test to the perf waterfall. (Closed)

Created:
8 years, 10 months ago by Robert Sesek
Modified:
8 years, 10 months ago
Reviewers:
cmp
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add Mach ports test to the perf waterfall. BUG=105513 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120079

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M masters/master.chromium.perf/master.cfg View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 1 chunk +15 lines, -0 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
8 years, 10 months ago (2012-01-31 21:25:08 UTC) #1
cmp
lgtm with nit Nice quick work. https://chromiumcodereview.appspot.com/9307012/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): https://chromiumcodereview.appspot.com/9307012/diff/1/scripts/master/factory/chromium_commands.py#newcode240 scripts/master/factory/chromium_commands.py:240: self.AddTestStep(c, 'mach_ports', cmd, ...
8 years, 10 months ago (2012-02-01 01:51:25 UTC) #2
Robert Sesek
https://chromiumcodereview.appspot.com/9307012/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): https://chromiumcodereview.appspot.com/9307012/diff/1/scripts/master/factory/chromium_commands.py#newcode240 scripts/master/factory/chromium_commands.py:240: self.AddTestStep(c, 'mach_ports', cmd, do_step_if=self.TestStepFilter) On 2012/02/01 01:51:25, cmp wrote: ...
8 years, 10 months ago (2012-02-01 18:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9307012/4001
8 years, 10 months ago (2012-02-01 18:39:28 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 18:41:20 UTC) #5 
Change committed as 120079

Powered by Google App Engine
This is Rietveld 408576698