Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 9307012: Add Mach ports test to the perf waterfall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.chromium.perf/master.cfg ('k') | scripts/master/factory/chromium_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/chromium_commands.py
diff --git a/scripts/master/factory/chromium_commands.py b/scripts/master/factory/chromium_commands.py
index 1596b1b5198a5b4caf22d4bb3f066d9f4d6df1e3..646aa9b2d298cae9aa10a8ae35e83ae4e2c0b3a9 100644
--- a/scripts/master/factory/chromium_commands.py
+++ b/scripts/master/factory/chromium_commands.py
@@ -228,6 +228,21 @@ class ChromiumCommands(commands.FactoryCommands):
'check lkgr and stop build if unchanged',
cmd)
+ def AddMachPortsTests(self, factory_properties=None):
+ """Adds the Mac-specific Mach ports count test."""
+ factory_properties = factory_properties or {}
+ c = self.GetPerfStepClass(factory_properties, 'mach_ports',
+ process_log.GraphingLogProcessor)
+
+ options = ['--gtest_filter=MachPortsTest.*']
+ cmd = self.GetTestCommand('performance_ui_tests', options,
+ factory_properties=factory_properties)
+
+ cmd = self.AddBuildProperties(cmd)
+ cmd = self.AddFactoryProperties(factory_properties, cmd)
+
+ self.AddTestStep(c, 'mach_ports', cmd, do_step_if=self.TestStepFilter)
+
def GetPageCyclerCommand(self, test_name, http, factory_properties=None):
"""Returns a command list to call the _test_tool on the page_cycler
executable, with the appropriate GTest filter and additional arguments.
« no previous file with comments | « masters/master.chromium.perf/master.cfg ('k') | scripts/master/factory/chromium_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698