Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 9301013: Disable ULDI on reference to libjpeg_turbo (vs2010) (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews
Visibility:
Public.

Description

Disable ULDI on reference to libjpeg_turbo (vs2010) UseLibraryDependencyInputs on VS2010 currently fails when linking .obj files generated from .asm. Disable ULDI for just this project. BUG=97534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M libjpeg.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
8 years, 10 months ago (2012-01-30 21:33:08 UTC) #1
Hironori Bono
LGTM. Thanks for your fix. Would it be possible to send a TBR change to ...
8 years, 10 months ago (2012-01-31 08:03:17 UTC) #2
scottmg
Thanks! Yes, I'll roll the DEPS once this has landed. On Tue, Jan 31, 2012 ...
8 years, 10 months ago (2012-01-31 15:11:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9301013/1
8 years, 10 months ago (2012-01-31 16:23:43 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 16:23:50 UTC) #5
Change committed as 119895

Powered by Google App Engine
This is Rietveld 408576698