Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 9297041: Merge Compositor and CompositorCC (Closed)

Created:
8 years, 11 months ago by piman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, piman+watch_chromium.org, James Su
Visibility:
Public.

Description

Merge Compositor and CompositorCC This also removes a few unused calls. BUG=None TEST=compiles, tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119645

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -821 lines) Patch
M build/common.gypi View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_linux.h View 1 1 chunk +12 lines, -10 lines 0 comments Download
A content/browser/renderer_host/accelerated_surface_container_linux.cc View 1 chunk +63 lines, -0 lines 0 comments Download
D content/browser/renderer_host/accelerated_surface_container_linux_cc.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M ui/aura/window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/gfx/compositor/compositor.h View 1 7 chunks +60 lines, -82 lines 0 comments Download
M ui/gfx/compositor/compositor.cc View 4 chunks +243 lines, -20 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/compositor/compositor_cc.h View 1 chunk +0 lines, -129 lines 0 comments Download
D ui/gfx/compositor/compositor_cc.cc View 1 chunk +0 lines, -323 lines 0 comments Download
M ui/gfx/compositor/layer.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/compositor/layer.cc View 1 2 5 chunks +14 lines, -23 lines 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/test/test_compositor_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/test/test_suite.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D ui/gfx/compositor/test/test_texture.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/gfx/compositor/test/test_texture.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M ui/views/widget/native_widget_gtk.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
8 years, 11 months ago (2012-01-28 00:14:01 UTC) #1
Ben Goodger (Google)
LGTM https://chromiumcodereview.appspot.com/9297041/diff/1/content/browser/renderer_host/accelerated_surface_container_linux.h File content/browser/renderer_host/accelerated_surface_container_linux.h (right): https://chromiumcodereview.appspot.com/9297041/diff/1/content/browser/renderer_host/accelerated_surface_container_linux.h#newcode19 content/browser/renderer_host/accelerated_surface_container_linux.h:19: class AcceleratedSurfaceContainerLinux: public ui::Texture { nit: space before ...
8 years, 11 months ago (2012-01-28 00:40:13 UTC) #2
piman
Couple of build fixes too. I'll wait for the trybot results and then kick it ...
8 years, 11 months ago (2012-01-28 01:50:35 UTC) #3
Ben Goodger (Google)
Nope. SG. On Fri, Jan 27, 2012 at 5:50 PM, <piman@chromium.org> wrote: > Couple of ...
8 years, 11 months ago (2012-01-28 04:26:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9297041/6002
8 years, 10 months ago (2012-01-29 17:41:58 UTC) #5
commit-bot: I haz the power
Can't apply patch for file ui/gfx/compositor/layer.cc. While running patch -p1 --forward --force; patching file ui/gfx/compositor/layer.cc ...
8 years, 10 months ago (2012-01-29 17:42:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9297041/6005
8 years, 10 months ago (2012-01-29 18:06:40 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-01-29 21:22:16 UTC) #8
Change committed as 119645

Powered by Google App Engine
This is Rietveld 408576698