Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 9296017: Remove static initializer for TLS object. This moves the TLS to the (Closed)

Created:
8 years, 10 months ago by brettw
Modified:
8 years, 10 months ago
Reviewers:
Nico, yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

Remove static initializer for TLS object. This moves the TLS to the PluginGlobals. I did not do a general sultion so that anybody can add to the globals TLS object because this may be the only place we need this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120500

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M ppapi/proxy/plugin_globals.h View 1 2 3 3 chunks +18 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.cc View 1 2 3 5 chunks +18 lines, -11 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
brettw
This is to remove a static initializer I added in my MessageLoop patch.
8 years, 10 months ago (2012-01-27 22:11:53 UTC) #1
yzshen1
lgtm
8 years, 10 months ago (2012-01-27 22:32:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9296017/7001
8 years, 10 months ago (2012-02-04 22:44:50 UTC) #3
commit-bot: I haz the power
Can't apply patch for file ppapi/proxy/ppb_message_loop_proxy.cc. While running patch -p0 --forward --force; patching file ppapi/proxy/ppb_message_loop_proxy.cc ...
8 years, 10 months ago (2012-02-04 22:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9296017/18001
8 years, 10 months ago (2012-02-04 23:18:52 UTC) #5
commit-bot: I haz the power
Change committed as 120500
8 years, 10 months ago (2012-02-05 03:07:40 UTC) #6
Nico
http://codereview.chromium.org/9296017/diff/18001/ppapi/proxy/ppb_message_loop_proxy.cc File ppapi/proxy/ppb_message_loop_proxy.cc (left): http://codereview.chromium.org/9296017/diff/18001/ppapi/proxy/ppb_message_loop_proxy.cc#oldcode29 ppapi/proxy/ppb_message_loop_proxy.cc:29: static base::ThreadLocalStorage::StaticSlot tls_slot = TLS_INITIALIZER; I think this stopped ...
8 years, 10 months ago (2012-02-05 03:13:37 UTC) #7
brettw
8 years, 10 months ago (2012-02-05 03:33:21 UTC) #8
http://codereview.chromium.org/9296017/diff/18001/ppapi/proxy/ppb_message_loo...
File ppapi/proxy/ppb_message_loop_proxy.cc (left):

http://codereview.chromium.org/9296017/diff/18001/ppapi/proxy/ppb_message_loo...
ppapi/proxy/ppb_message_loop_proxy.cc:29: static
base::ThreadLocalStorage::StaticSlot tls_slot = TLS_INITIALIZER;
On 2012/02/05 03:13:37, Nico wrote:
> I think this stopped needing a static initializer after
http://crrev.com/119679.

Yeah, I did this patch actually before you wrote yours, and I kept it because I
like the new design better since it avoids the statics altogether.

Powered by Google App Engine
This is Rietveld 408576698