Remove static initializer for TLS object. This moves the TLS to the

ppapi/proxy/ppb_message_loop_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_message_loop_proxy.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
-#include "base/threading/thread_local_storage.h"
 #include "ppapi/c/dev/ppb_message_loop_dev.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
+#include "ppapi/proxy/plugin_globals.h"
 #include "ppapi/shared_impl/resource.h"
 #include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/ppb_message_loop_api.h"
 
 using ppapi::thunk::PPB_MessageLoop_API;
 
 namespace ppapi {
 namespace proxy {
 
 namespace {
 
 typedef thunk::EnterResource<PPB_MessageLoop_API> EnterMessageLoop;
 
-static base::ThreadLocalStorage::StaticSlot tls_slot = TLS_INITIALIZER;

[Nico, 2012/02/05 03:13:37]

I think this stopped needing a static initializer after http://crrev.com/119679.

[brettw, 2012/02/05 03:33:21]

Yeah, I did this patch actually before you wrote yours, and I kept it because I
like the new design better since it avoids the statics altogether.

-
 class MessageLoopResource : public Resource, public PPB_MessageLoop_API {
  public:
   MessageLoopResource(PP_Instance instance);
   virtual ~MessageLoopResource();
 
   // Resource overrides.
   virtual PPB_MessageLoop_API* AsPPB_MessageLoop_API() OVERRIDE;
 
   // PPB_MessageLoop_API implementation.
   virtual int32_t AttachToCurrentThread() OVERRIDE;
@@ skipping 54 matching lines @@
 }
 
 MessageLoopResource::~MessageLoopResource() {
 }
 
 PPB_MessageLoop_API* MessageLoopResource::AsPPB_MessageLoop_API() {
   return this;
 }
 
 int32_t MessageLoopResource::AttachToCurrentThread() {
-  if (tls_slot.initialized())
-    return PP_ERROR_INPROGRESS;
+  PluginGlobals* globals = PluginGlobals::Get();
+
+  base::ThreadLocalStorage::Slot* slot = globals->msg_loop_slot();
+  if (!slot) {
+    slot = new base::ThreadLocalStorage::Slot(&ReleaseMessageLoop);
+    globals->set_msg_loop_slot(slot);
+  } else {
+    if (slot->Get())
+      return PP_ERROR_INPROGRESS;
+  }
   // TODO(brettw) check that the current thread can support a message loop.
 
   // Take a ref to the MessageLoop on behalf of the TLS. Note that this is an
   // internal ref and not a plugin ref so the plugin can't accidentally
   // release it. This is released by ReleaseMessageLoop().
   AddRef();
-  tls_slot.Initialize(&ReleaseMessageLoop);
-  tls_slot.Set(this);
+  slot->Set(this);
 
   loop_.reset(new MessageLoop(MessageLoop::TYPE_DEFAULT));
 
   // Post all pending work to the message loop.
   for (size_t i = 0; i < pending_tasks_.size(); i++) {
     const TaskInfo& info = pending_tasks_[i];
     PostClosure(info.from_here, info.closure, info.delay_ms);
   }
   pending_tasks_.clear();
 
@@ skipping 48 matching lines @@
   // Note that the message loop must be destroyed on the thread is was created
   // on.
   loop_.reset();
 
   // Cancel out the AddRef in AttachToCurrentThread().
   Release();
   // DANGER: may delete this.
 }
 
 bool MessageLoopResource::IsCurrent() const {
-  if (!tls_slot.initialized())
+  PluginGlobals* globals = PluginGlobals::Get();
+  if (!globals->msg_loop_slot())
     return false;  // Can't be current if there's nothing in the slot.
-  return static_cast<const void*>(tls_slot.Get()) ==
+  return static_cast<const void*>(globals->msg_loop_slot()->Get()) ==
          static_cast<const void*>(this);
 }
 
 void MessageLoopResource::PostClosure(
     const tracked_objects::Location& from_here,
     const base::Closure& closure,
     int64 delay_ms) {
   if (loop_.get()) {
     loop_->PostDelayedTask(
         from_here, closure, base::TimeDelta::FromMilliseconds(delay_ms));
@@ skipping 20 matching lines @@
     return 0;
   return (new MessageLoopResource(instance))->GetReference();
 }
 
 PP_Resource GetForMainThread() {
   // TODO(brettw).
   return 0;
 }
 
 PP_Resource GetCurrent() {
-  if (!tls_slot.initialized())
+  PluginGlobals* globals = PluginGlobals::Get();
+  if (!globals->msg_loop_slot())
     return 0;
   MessageLoopResource* loop = reinterpret_cast<MessageLoopResource*>(
-      tls_slot.Get());
+      globals->msg_loop_slot()->Get());
   return loop->GetReference();
 }
 
 int32_t AttachToCurrentThread(PP_Resource message_loop) {
   EnterMessageLoop enter(message_loop, true);
   if (enter.succeeded())
     return enter.object()->AttachToCurrentThread();
   return PP_ERROR_BADRESOURCE;
 }
 
@@ skipping 39 matching lines @@
 PPB_MessageLoop_Proxy::~PPB_MessageLoop_Proxy() {
 }
 
 // static
 const PPB_MessageLoop_Dev_0_1* PPB_MessageLoop_Proxy::GetInterface() {
   return &ppb_message_loop_interface;
 }
 
 }  // namespace proxy
 }  // namespace ppapi