Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 9288008: linux: don't make -Werror setting conditional on OS (Closed)

Created:
8 years, 11 months ago by Evan Martin
Modified:
8 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

linux: don't make -Werror setting conditional on OS People who need to adjust this should adjust it directly. Guessing just makes everything more confusing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119092

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
8 years, 11 months ago (2012-01-25 00:38:06 UTC) #1
Nico
lgtm
8 years, 11 months ago (2012-01-25 00:47:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9288008/3002
8 years, 11 months ago (2012-01-25 16:23:31 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 18:32:32 UTC) #4
Change committed as 119092

Powered by Google App Engine
This is Rietveld 408576698