Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 9288008: linux: don't make -Werror setting conditional on OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 04344b642361586a9cfb7ee9a57d5c0b5bc863c1..46d383a022ecf06e18bc3b9ed0cea01c5fc82627 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1654,13 +1654,7 @@
# Enable -Werror by default, but put it in a variable so it can
# be disabled in ~/.gyp/include.gypi on the valgrind builders.
'variables': {
- 'conditions': [
- ['OS=="linux"', {
- 'werror%': '-Werror',
- }, { # turn off -Werror on other Unices
- 'werror%': '',
- }],
- ],
+ 'werror%': '-Werror',
},
'cflags': [
'<(werror)', # See note above about the werror variable.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698