Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/isolate.cc

Issue 9271008: Implement deletion of breakpoints (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/debugger_api_impl_test.cc ('K') | « runtime/vm/debugger_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 3444)
+++ runtime/vm/isolate.cc (working copy)
@@ -264,6 +264,15 @@
ASSERT(top_resource_ == NULL);
ASSERT((heap_ == NULL) || heap_->Verify());
+ // Clean up debugger resources. We shutting down the debugger
+ // requires a handle zone. We must set up a temporary zone because
siva 2012/01/20 21:26:29 The comment seems hard to read, is "We shutting do
hausner 2012/01/20 22:20:32 Leftover junk from previous version of comment. Fi
+ // Isolate::Shutdown is called without a zone.
+ if (true) {
siva 2012/01/20 21:26:29 Why not just { Zone zone(this); ... ... }
hausner 2012/01/20 22:20:32 Done.
+ Zone zone(this);
+ HandleScope handle_scope(this);
+ debugger_->Shutdown();
+ }
+
// Close all the ports owned by this isolate.
PortMap::ClosePorts();
« runtime/vm/debugger_api_impl_test.cc ('K') | « runtime/vm/debugger_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698