Implement deletion of breakpoints

runtime/vm/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_store.h"
 #include "vm/code_index_table.h"
@@ skipping 246 matching lines @@
         invoked_functions[i]->ToFullyQualifiedCString());
   }
 }
 
 
 void Isolate::Shutdown() {
   ASSERT(this == Isolate::Current());
   ASSERT(top_resource_ == NULL);
   ASSERT((heap_ == NULL) || heap_->Verify());
 
+  // Clean up debugger resources. We shutting down the debugger
+  // requires a handle zone. We must set up a temporary zone because

[siva, 2012/01/20 21:26:29]

The comment seems hard to read, is "We shutting down the debugger requires a
handle zone" required?

[hausner, 2012/01/20 22:20:32]

Leftover junk from previous version of comment. Fixed.

+  // Isolate::Shutdown is called without a zone.
+  if (true) {

[siva, 2012/01/20 21:26:29]

Why not just
{
  Zone zone(this);
  ...
  ...
}

[hausner, 2012/01/20 22:20:32]

Done.

+    Zone zone(this);
+    HandleScope handle_scope(this);
+    debugger_->Shutdown();
+  }
+
   // Close all the ports owned by this isolate.
   PortMap::ClosePorts();
 
   delete message_queue();
   set_message_queue(NULL);
 
   // Dump all accumalated timer data for the isolate.
   timer_list_.ReportTimers();
   if (FLAG_report_invocation_count) {
     PrintInvokedFunctions();
@@ skipping 118 matching lines @@
 }
 
 
 void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor) {
   if (api_state() != NULL) {
     api_state()->VisitWeakHandles(visitor);
   }
 }
 
 }  // namespace dart