Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: chrome/browser/extensions/webstore_inline_installer.h

Issue 9269020: Handle paths and ports in verified domains in inline install. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_inline_installer.h
diff --git a/chrome/browser/extensions/webstore_inline_installer.h b/chrome/browser/extensions/webstore_inline_installer.h
index 96aedfbc05648a4d87630a812e0d249d2304cb02..df66c3c9e6e5855a42d4b27ff8fee0021b9c5851 100644
--- a/chrome/browser/extensions/webstore_inline_installer.h
+++ b/chrome/browser/extensions/webstore_inline_installer.h
@@ -52,6 +52,7 @@ class WebstoreInlineInstaller
private:
friend class base::RefCountedThreadSafe<WebstoreInlineInstaller>;
friend class SafeWebstoreResponseParser;
+ FRIEND_TEST_ALL_PREFIXES(WebstoreInlineInstallerTest, DomainVerification);
virtual ~WebstoreInlineInstaller();
@@ -100,6 +101,11 @@ class WebstoreInlineInstaller
void CompleteInstall(const std::string& error);
+ // Checks whether the install is initiated by a page in the verified site
+ // (which is at least a domain, but can also have a port or a path).
+ static bool IsRequestorUrlInVerifiedSite(const GURL& requestor_url,
jstritar 2012/01/25 17:40:28 nit: we try to use URL rather than Url in extensio
Mihai Parparita -not on Chrome 2012/01/25 18:11:04 Done.
+ const std::string& verified_site);
+
int install_id_;
std::string id_;
GURL requestor_url_;

Powered by Google App Engine
This is Rietveld 408576698