Handle paths and ports in verified domains in inline install.

chrome/browser/extensions/webstore_inline_installer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 34 matching lines @@
   WebstoreInlineInstaller(content::WebContents* web_contents,
                           int install_id,
                           std::string webstore_item_id,
                           GURL requestor_url,
                           Delegate* d);
   void BeginInstall();
 
  private:
   friend class base::RefCountedThreadSafe<WebstoreInlineInstaller>;
   friend class SafeWebstoreResponseParser;
+  FRIEND_TEST_ALL_PREFIXES(WebstoreInlineInstallerTest, DomainVerification);
 
   virtual ~WebstoreInlineInstaller();
 
   // Several delegate/client inteface implementations follow. The normal flow
   // (for successful installs) is:
   //
   // 1. BeginInstall: starts the fetch of data from the webstore
   // 2. OnURLFetchComplete: starts the parsing of data from the webstore
   // 3. OnWebstoreResponseParseSuccess: starts the parsing of the manifest and
   //    fetching of icon data.
@@ skipping 28 matching lines @@
   virtual void WebContentsDestroyed(
       content::WebContents* web_contents) OVERRIDE;
 
   // WebstoreInstaller::Delegate interface implementation.
   virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
   virtual void OnExtensionInstallFailure(const std::string& id,
                                          const std::string& error) OVERRIDE;
 
   void CompleteInstall(const std::string& error);
 
+  // Checks whether the install is initiated by a page in the verified site
+  // (which is at least a domain, but can also have a port or a path).
+  static bool IsRequestorUrlInVerifiedSite(const GURL& requestor_url,

[jstritar, 2012/01/25 17:40:28]

nit: we try to use URL rather than Url in extensions code

[Mihai Parparita -not on Chrome, 2012/01/25 18:11:04]

Done.

+                                           const std::string& verified_site);
+
   int install_id_;
   std::string id_;
   GURL requestor_url_;
   Delegate* delegate_;
 
   // For fetching webstore JSON data.
   scoped_ptr<content::URLFetcher> webstore_data_url_fetcher_;
 
   // Extracted from the webstore JSON data response.
   std::string localized_name_;
   std::string localized_description_;
   std::string localized_user_count_;
   double average_rating_;
   int rating_count_;
   scoped_ptr<DictionaryValue> webstore_data_;
   scoped_ptr<DictionaryValue> manifest_;
   scoped_refptr<Extension> dummy_extension_;
   SkBitmap icon_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(WebstoreInlineInstaller);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_