Handle paths and ports in verified domains in inline install.

Handle paths and ports in verified domains in inline install.

The web store can have paths and ports in the verified domain (see verified_site value in
https://chrome.google.com/webstore/inlineinstall/detail/phlfmndgellgadekoplejihbfoeghhgf).
Use URLPattern::Parse to parse the verified site, so that we can match all of these things.

R=jstritar@chromium.org
BUG=110917
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119115

[jstritar, 2012-01-23 21:37:28]

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_inline_installer.cc (left):

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_inline_installer.cc:305:
verified_site_pattern.SetHost(verified_site_domain);
URLPattern already handles a lot of this if you use Parse. Maybe something like
this?

if (success != verified_site_pattern.Parse(StringPrintF("http://*.%s/*",
domain)))
  error
verified_site_pattern.SetScheme("*")

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_inline_installer.cc:314: // allow specific
ports unless the scheme has a default port.
Hm, strange, is this a bug?

[Mihai Parparita -not on Chrome, 2012-01-25 00:53:23]

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_inline_installer.cc (left):

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_inline_installer.cc:305:
verified_site_pattern.SetHost(verified_site_domain);
On 2012/01/23 21:37:28, jstritar wrote:
> URLPattern already handles a lot of this if you use Parse.

Yeah, that ended up being easier, especially since it turned out that verified
sites can have paths too.

Also added a unit test for this, since that was much easier than additional
browser tests.

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/9269020/diff/6/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_inline_installer.cc:314: // allow specific
ports unless the scheme has a default port.
On 2012/01/23 21:37:28, jstritar wrote:
> Hm, strange, is this a bug?

It appears to be intentional behavior (see IsValidPortForScheme in
url_pattern.cc).

[jstritar, 2012-01-25 17:40:27]

nice, LGTM

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.h (right):

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:106: static bool
IsRequestorUrlInVerifiedSite(const GURL& requestor_url,
nit: we try to use URL rather than Url in extensions code

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer_unittest.cc (right):

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer_unittest.cc:64:
"http://example.com:123/path/page.html", "example.com:123/path"));
How about one more test for when there's a path that doesn't match?

EXPECT_FALSE(IsVerified("http://example.com", "example.com/path"));

[Mihai Parparita -not on Chrome, 2012-01-25 18:10:59]

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.h (right):

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:106: static bool
IsRequestorUrlInVerifiedSite(const GURL& requestor_url,
On 2012/01/25 17:40:28, jstritar wrote:
> nit: we try to use URL rather than Url in extensions code

Done.

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer_unittest.cc (right):

http://codereview.chromium.org/9269020/diff/11001/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer_unittest.cc:64:
"http://example.com:123/path/page.html", "example.com:123/path"));
On 2012/01/25 17:40:28, jstritar wrote:
> How about one more test for when there's a path that doesn't match?
> 
> EXPECT_FALSE(IsVerified("http://example.com", "example.com/path"));

Done.

[commit-bot: I haz the power, 2012-01-25 18:11:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/9269020/9005

[commit-bot: I haz the power, 2012-01-25 20:33:36]

Change committed as 119115