Issue 9264058: Debugger API: get local variables of an activation frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9264058: Debugger API: get local variables of an activation frame (Closed)

Created:
8 years, 10 months ago by hausner

Modified:
8 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Debugger API: get local variables of an activation frame Also add a test case where the evaluation of a field name results in an error during the evaluation of the field. Committed: https://code.google.com/p/dart/source/detail?r=3738

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -10 lines)			Patch
M	runtime/include/dart_debugger_api.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View	1	4 chunks	+58 lines, -7 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	4 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/9264058/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): http://codereview.chromium.org/9264058/diff/1/runtime/vm/debugger.cc#newcode182 runtime/vm/debugger.cc:182: intptr_t desc_len = desc_indices_.length(); Could we rename this ...

8 years, 10 months ago (2012-01-31 01:16:04 UTC) #2

hausner

8 years, 10 months ago (2012-01-31 17:40:07 UTC) #3

Thank you.

http://codereview.chromium.org/9264058/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/9264058/diff/1/runtime/vm/debugger.cc#newcode182
runtime/vm/debugger.cc:182: intptr_t desc_len = desc_indices_.length();
On 2012/01/31 01:16:04, asiva wrote:
> Could we rename this variable to something else it hides
> desc_len from above and makes it hard to read the code.

Done.

http://codereview.chromium.org/9264058/diff/1/runtime/vm/debugger.cc#newcode251
runtime/vm/debugger.cc:251: list.SetAt(2 * i + 1, value);
On 2012/01/31 01:16:04, asiva wrote:
> (2 * i) + 1, value
> would make it more readable for people who are always operator precedence
> challenged.

Done.

Expand Messages | Collapse Messages