Issue 9252027: Fix named parameter function calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9252027: Fix named parameter function calls (Closed)

Created:
8 years, 11 months ago by hausner

Modified:
8 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix named parameter function calls Issue 1199 Committed: https://code.google.com/p/dart/source/detail?r=3422

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	runtime/vm/parser.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	tests/language/src/NamedParametersTest.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one style nit. http://codereview.chromium.org/9252027/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/9252027/diff/1/runtime/vm/parser.cc#newcode7585 runtime/vm/parser.cc:7585: if (IsIdentifier() && LookaheadToken(1) ...

8 years, 11 months ago (2012-01-19 00:36:48 UTC) #2

hausner

8 years, 11 months ago (2012-01-19 00:47:33 UTC) #3

Thanks!

http://codereview.chromium.org/9252027/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/9252027/diff/1/runtime/vm/parser.cc#newcode7585
runtime/vm/parser.cc:7585: if (IsIdentifier() && LookaheadToken(1) ==
Token::kCOLON) {
On 2012/01/19 00:36:48, regis wrote:
> Please add a pair of parenthesis.

Done.

Expand Messages | Collapse Messages

Issue 9252027: Fix named parameter function calls (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages