Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 9251012: Fix standalone tests that didn't delete the temporary directories they created. (Closed)

Created:
8 years, 11 months ago by Bill Hesse
Modified:
8 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix standalone tests that didn't delete the temporary directories they created. BUG= TEST=tools/test.py standalone; ls /tmp/temp_dir* Committed: https://code.google.com/p/dart/source/detail?r=3396

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -31 lines) Patch
M tests/standalone/src/FileTest.dart View 5 chunks +48 lines, -31 lines 1 comment Download
M tests/standalone/src/StreamPipeTest.dart View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
http://codereview.chromium.org/9251012/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (left): http://codereview.chromium.org/9251012/diff/1/tests/standalone/src/FileTest.dart#oldcode211 tests/standalone/src/FileTest.dart:211: file.openHandler = (RandomAccessFile openedfile) { This was the error ...
8 years, 11 months ago (2012-01-18 14:51:25 UTC) #1
Søren Gjesse
8 years, 11 months ago (2012-01-18 15:36:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698