Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9241029: sync: Pass ProfileSyncService to NonFrontendDataTypeController's ctor (Closed)

Created:
8 years, 11 months ago by tim (not reviewing)
Modified:
8 years, 11 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, mihaip+watch_chromium.org, Aaron Boodman, dyu1, dhollowa+watch_chromium.org, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

sync: Pass ProfileSyncService to NonFrontendDataTypeController's ctor BUG=93922 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -35 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tim (not reviewing)
8 years, 11 months ago (2012-01-17 22:54:21 UTC) #1
Andrew T Wilson (Slow)
On 2012/01/17 22:54:21, timsteele wrote: LGTM
8 years, 11 months ago (2012-01-17 23:40:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/9241029/1
8 years, 11 months ago (2012-01-17 23:45:42 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-18 04:17:02 UTC) #4 
Change committed as 118041

Powered by Google App Engine
This is Rietveld 408576698